Extract simulation part of snaps-jest to separate package
#2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
==========================================
- Coverage 94.36% 94.35% -0.01%
==========================================
Files 481 476 -5
Lines 10152 10137 -15
Branches 1542 1542
==========================================
- Hits 9580 9565 -15
Misses 572 572 ☔ View full report in Codecov by Sentry. |
david0xd
reviewed
Sep 17, 2024
david0xd
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts all simulation logic from
snaps-jestto a new packagesnaps-simulation(not to be confused withsnaps-simulator). This makes it possible to use the simulation framework outside of Jest, for example to run a Snap in any Node.js application. It will also enable removing the simulation framework used bysnaps-simulatorto reduce code duplication, and improve maintainability.